Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache that DNS UDP query led to TC #742

Open
miekg opened this Issue May 27, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@miekg
Copy link

miekg commented May 27, 2015

Currently the code in retrieval/discovery/dns.go always does a UDP lookup first. When this returns a truncated packet, a TCP query is tried instead. So far so good.

I think it makes sense to implement some kind of caching here, so once a TC bit is seen for a name, only TCP queries are done for the next X minutes (or whatever).

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 27, 2015

That's certainly an optimization we should consider.
I don't think it's urgent for now, though, as the number of DNS requests is
completely shadowed by the number of target scrapes.

It might take a while until we get to it – PRs are always welcome, of
course :)

On Wed, May 27, 2015 at 4:20 PM Miek Gieben notifications@github.com
wrote:

Currently the code in retrieval/discovery/dns.go always does a UDP lookup
first. When this returns a truncated packet, a TCP query is tried instead.
So far so good.

I think it makes sense to implement some kind of caching here, so once a
TC bit is seen for a name, only TCP queries are done for the next X minutes
(or whatever).


Reply to this email directly or view it on GitHub
#742.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.