Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncated tcp messages #749

Closed
miekg opened this Issue May 29, 2015 · 4 comments

Comments

Assignees
No one assigned
Labels
component/service discovery kind/enhancement priority/Pmaybe
Projects
None yet
Milestone
No milestone
4 participants
@miekg @brian-brazil @grobie @fabxc
@miekg
Copy link

miekg commented May 29, 2015

Do to a small fubar of mine SkyDNS set the TC bit on TCP messages. Prometheus does not like/use those for resolving purposes. I think it makes sense to have an extra check to see if the message size is 64K bytes and if the message is smaller, just ignore the TC bit, and use the data inside the message.

Logging such messages still makes sense.
@miekg

This comment has been minimized.

Sign in to view
Copy link
Author

miekg commented May 30, 2015

This might (also) be an issue in Go DNS, I'll check that too.

@brian-brazil brian-brazil added the enhancement label Dec 16, 2015

@fabxc fabxc added kind/enhancement and removed enhancement labels Apr 28, 2016

@brian-brazil

This comment has been minimized.

Sign in to view
Copy link
Member

brian-brazil commented Jul 14, 2017

Is there an update here? Is this something we as a user of the library should have to care about?

@brian-brazil brian-brazil added priority/Pmaybe component/service discovery labels Jul 14, 2017

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

@brian-brazil
Clarify directly instrumention vs merely exposing. (prometheus#749) 
Directly instrumented applications use a Prometheus client library that
follows our guidelines, and can be used as examples of software doing
that.

Recategorise things accordingly, updating links as needed and
adding some more I know of.
I'm taking Quobyte's word for it that they're directly instrumented,
as it's commercial software and thus I can't check.
kubernetes-mesos has no instrumentation that I can find.
63e9460
@grobie

This comment has been minimized.

Sign in to view
Copy link
Member

grobie commented Nov 12, 2017

This doesn't make sense. It should not be Prometheus' task to second-guess whether a DNS server should not have set the truncation bit and ignore it. The DNS spec is pretty clear about the interface.

@grobie grobie closed this Nov 12, 2017

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.