Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nil panic for missing regexp in relabel config #787

Closed
discordianfish opened this Issue Jun 10, 2015 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@discordianfish @fabxc
@discordianfish
Copy link
Member

discordianfish commented Jun 10, 2015

If you omit the regexp from a relabel config, prometheus starts and crashes because of nil pointer dereference:

goroutine 56 [running]:
github.com/prometheus/prometheus/retrieval.relabel(0xc20949aea0, 0xc2081886c0, 0xc20949aea0, 0x0, 0x0)
    /go/src/github.com/prometheus/prometheus/retrieval/relabel.go:50 +0x62c
github.com/prometheus/prometheus/retrieval.Relabel(0xc20949ac90, 0xc20818a620, 0x3, 0x3, 0xc209285dc8, 0x0, 0x0)
    /go/src/github.com/prometheus/prometheus/retrieval/relabel.go:22 +0x1f1

fabxc added a commit that referenced this issue Jun 10, 2015

@fabxc
config: error on missing regex in relabel config. 
Fixes issue #787.
Loading status checks…
4585505
@fabxc

This comment has been minimized.

Sign in to view
Copy link
Member

fabxc commented Jun 10, 2015

Thanks

@fabxc fabxc closed this Jun 10, 2015

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.