Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule_checker does not indicate if a rule is keeping_extra #794

Closed
jaqx0r opened this Issue Jun 12, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@jaqx0r
Copy link

jaqx0r commented Jun 12, 2015

The following rules:

job:errors:rate10s_nokeep = sum(task:errors:rate10s{job="s"}) by (code)
job:errors:rate10s = sum(task:errors:rate10s{job="s"}) by (code) keeping_extra

are printed as

job:errors:rate10s_nokeep = sum(task:errors:rate10s{job="s"}) BY (code)
job:errors:rate10s = sum(task:errors:rate10s{job="s"}) BY (code)

by rule_checker.

I'd expect the keeping_extra clause to remain as it's part of the rule.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Jun 12, 2015

Thanks, will be fixed in master soon.

@fabxc fabxc closed this in c716d8a Jun 12, 2015

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.