Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of Basic Credentials in the web UI #862

Closed
bluecmd opened this Issue Jun 26, 2015 · 5 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bluecmd @fabxc @juliusv
@bluecmd
Copy link
Contributor

bluecmd commented Jun 26, 2015

For targets using basic credentials:

  1. 0.14 used to construct and display a URL with embedded credentials in it. This disappeared in 0.15rc0.
    Expected behavior: The link should be generated with something like https://host:1234/metrics. Note the suggestion to not display the credentials but only embed them.

  2. It would be nice if the credentials were masked in the configuration dump in the UI.
@bluecmd

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bluecmd commented Jun 26, 2015

Ping @fabxc
@fabxc

This comment has been minimized.

Sign in to view
Copy link
Member

fabxc commented Jul 6, 2015

  1. Is already/still how it works. Chrome doesn't show the credentials in the bottom-left corner on hovering but they are in the actual href tag.

  2. Is solved in #876
@bluecmd

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bluecmd commented Jul 6, 2015

  1. Ah, so it is. My bad.

  2. Neat!
@juliusv

This comment has been minimized.

Sign in to view
Copy link
Member

juliusv commented Jul 22, 2015

Looks like this is solved now, closing. Reopen please if you're still missing something :)

@juliusv juliusv closed this Jul 22, 2015

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.