Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPopulate timestamps in chunkDesc ASAP #891
Comments
beorn7
self-assigned this
Jul 13, 2015
beorn7
added
the
enhancement
label
Jul 13, 2015
beorn7
referenced this issue
Feb 12, 2016
Merged
Populate first and last time in the chunk descriptor earlier #1387
beorn7
closed this
Feb 15, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
beorn7 commentedJul 13, 2015
Currently, the timestamps in the chunkDesc are populated upon eviction. However, the first timestamp could be set after the first sample has been added. And the last timestamp could be set once the chunk is complete. And then we can make use of it at many places instead of digging down into the actual chunk. (Especially the lastTime call is relatively expensive.)
lastTime and firstTime methods simply could check for timestamp at zero value and in that case dig down into the chunk.