Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upQuerying labels that return no results when mixing regex and equality label matches returns results from other series #924
Comments
This comment has been minimized.
This comment has been minimized.
|
Wow! I can definitely reproduce it with a Prometheus that just scrapes itself and this query:
...it returns all kinds of time series. Will investigate ASAP, although I might not get to it today because we're on an offsite until Friday. Thanks for reporting! |
juliusv
referenced this issue
Jul 23, 2015
Merged
Only do regex lookups when there was no equality match. #927
This comment has been minimized.
This comment has been minimized.
|
Issue identified. Fix PR is out: #927 |
This comment has been minimized.
This comment has been minimized.
|
Thanks for reporting and fixing! On Thu, Jul 23, 2015, 10:59 PM Julius Volz notifications@github.com wrote:
|
juliusv
added a commit
that referenced
this issue
Jul 23, 2015
This comment has been minimized.
This comment has been minimized.
|
Thanks for sneaking in a look at this @juliusv |
juliusv
closed this
in
#927
Jul 24, 2015
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
pdf commentedJul 23, 2015
The following queries all return the expected results, when there are results to return, and no results when not all label queries match:
Where
validinstance/validmonitorare values that return results, andinvalidinstance/invalidmonitorare values that should not return results, andinvalidlabelis a label that doesn't exist. The regex anchors are options, they have no bearing on the issue.However, mixing regex and equality label matches as in the following queries returns results from completely different series when one of the labels would return results, but the other would not:
I may have missed some permutations above, but I think the scenario should be clear? I don't have test results with data right now, because I blew away my storage to make sure it was a query language problem rather than some sort of data storage corruption. This scenario does apply to querying any series though, so if you like I can provide some arbitrary results that illustrate the problem.
This was all tested on v0.15.0rc3