Unary expressions like `+++++++---------++++++1` shouldn't be valid

[juliusv]

E.g. +++++++---------++++++1 returns -1. Guess it should be a parse error?

[juliusv]

@fabxc

[juliusv]

Reason is the recursion here:

prometheus/promql/parse.go

Line 554 in 5279d50

e := p.unaryExpr()

[fabxc]

Yes. This is very much intended and valid. Why would this be a parsing error?

[brian-brazil]

In that case, why is -If a parse error? It's not currently documented that we have unary operators.

[fabxc]

-If is a runtime panic based on an unrelated bug. It's fixed in #954.
Unary expressions exist for number literals. Applying it to a vector or matrix errors "expected type scalar in unary expression, got vector". This is no new behavior.

[juliusv]

Ok yeah, though Go, JS, and some other languages don't allow this notation, Python seemingly does. And you can make a case for that it makes sense. So fine to close this from my side then.

[juliusv]

(but yeah, it might be cool do allow -foo as well)

[fabxc]

Yes, I'll open a separate issue for that.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.