Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords should be valid metric names #963

Closed
brian-brazil opened this Issue Aug 4, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@brian-brazil
Copy link
Member

brian-brazil commented Aug 4, 2015

Currently an expression such as if is invalid due to it being a keyword. As we won't limit metric not to clash with keywords, we should allow any valid metric name to be used in promql.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Aug 4, 2015

I don't see the practical necessity of this considering the implementation complexity it ships with. This will be absolutely nasty to parse for alerting rules.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Sep 21, 2015

I don't think this will ever happen and nor do I consider it necessary.
I would like to close issues that are not going to be tackled. Our keywords are mostly single-worded while metrics are generally multi-worded, so the conflict-potential is minimal. There is always the workaround through __name__ should there actually ever be a conflict.

Thoughts?

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Sep 22, 2015

👍 for closing for now and potentially reopening in the distant future if the need really ever becomes apparent.

@fabxc fabxc closed this Sep 22, 2015

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.