Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMarathon SD hardcodes expectation of a "prometheus" label #979
Comments
This comment has been minimized.
This comment has been minimized.
|
Closed via #987 |
fabxc
closed this
Aug 14, 2015
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
brian-brazil commentedAug 11, 2015
isValidAppis requiring the presence of aprometheuslabel for SD to work for a target. This is not going to be true in the general case, so instead all the labels should be exposed as meta labels and users with such a requirement can use relabelling to get just the targets they want.