deleting *.tmp WAL files on startup #10317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lihaowei <haoweili35@gmail.com>
codesome
reviewed
Feb 24, 2022
Signed-off-by: lihaowei <haoweili35@gmail.com>
codesome
reviewed
Mar 2, 2022
|
@codesome PTAL |
Harkishen-Singh
suggested changes
Mar 11, 2022
|
I think the issue also involves cleaning up |
codesome
approved these changes
Mar 15, 2022
I see that the issue is titled (and describes) deleting checkpoint dirs, so it should be fine to close it. (the meta.json.tmp file stuff is in code comment, which is still intact) |
Harkishen-Singh
approved these changes
Mar 15, 2022
Signed-off-by: lihaowei <haoweili35@gmail.com>
Signed-off-by: lihaowei <haoweili35@gmail.com>
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lihaowei haoweili35@gmail.com
Resolves #10245