Build with Go 1.18 #10501
Merged
Build with Go 1.18 #10501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this rebased on top of main? |
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
|
It wasn't, it is now. |
|
can we delay the golint update? |
|
I guess we can as long as we don't use generic code. |
|
I let you decide. Either we update and fix warnings, or we delay. I am fine with both. |
|
i'll fix the warning then. |
sylr
force-pushed
the
go1.18
branch
2 times, most recently
from
1038672
to
969edcc
Compare
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
|
Thanks! |
xinau
pushed a commit
to xinau/prometheus
that referenced
this pull request
Apr 1, 2022
* Build with Go 1.18 * Update golangci-lint version Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sylvain Rabot sylvain@abstraction.fr