New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to assume a role for ec2 discovery #2895

Merged
merged 1 commit into from Sep 9, 2017

Conversation

Projects
None yet
5 participants
@jamiemoore
Contributor

jamiemoore commented Jul 4, 2017

Adds the option to assume a role during ec2 discovery. Unlike using a profile this does not require a static set of credentials.

Add the following to your ec2 discovery config if you would like use the feature.
rolearn: 'arn:aws:iam::account-id:role/role-name'

@brian-brazil Please let me know if you would like any more information or require any changes.

@cornelf

This comment has been minimized.

Show comment
Hide comment
@cornelf

cornelf commented Jul 18, 2017

👍

@mdlayher

LGTM

Show outdated Hide outdated discovery/ec2/ec2.go
Show outdated Hide outdated config/config.go
@jamiemoore

This comment has been minimized.

Show comment
Hide comment
@jamiemoore

jamiemoore Sep 9, 2017

Contributor

@grobie are you happy with the changes?

Contributor

jamiemoore commented Sep 9, 2017

@grobie are you happy with the changes?

@grobie

This comment has been minimized.

Show comment
Hide comment
@grobie

grobie Sep 9, 2017

Member

Thanks, looks good! Please open a PR against the next_release branch in prometheus/docs, document the new field and mention me. I'll merge both PRs afterwards.

Member

grobie commented Sep 9, 2017

Thanks, looks good! Please open a PR against the next_release branch in prometheus/docs, document the new field and mention me. I'll merge both PRs afterwards.

@grobie

grobie approved these changes Sep 9, 2017

Thanks!

@grobie grobie merged commit 8bee283 into prometheus:master Sep 9, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jamiemoore jamiemoore deleted the jamiemoore:ec2_discovery_rolearn branch Sep 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment