New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose service clusterIP #3275

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@BasPH
Contributor

BasPH commented Oct 10, 2017

Expose Kubernetes service clusterIP as meta label as suggested in #3110. The full label has the name __meta_kubernetes_service_clusterIP.

BasPH added some commits Oct 10, 2017

@fabxc

This comment has been minimized.

Show comment
Hide comment
@fabxc

fabxc Oct 13, 2017

Member

Based on how we converted the K8S var names so far it sohuld probably be ..._cluster_ip

Member

fabxc commented Oct 13, 2017

Based on how we converted the K8S var names so far it sohuld probably be ..._cluster_ip

@brancz

This comment has been minimized.

Show comment
Hide comment
@brancz

brancz Oct 13, 2017

Member

Not that it does any harm to add this, I am curious though what you're intending to use this label for?

Member

brancz commented Oct 13, 2017

Not that it does any harm to add this, I am curious though what you're intending to use this label for?

@grobie

This comment has been minimized.

Show comment
Hide comment
@grobie

grobie Nov 11, 2017

Member

@BasPH Can you elaborate on the use case?

Member

grobie commented Nov 11, 2017

@BasPH Can you elaborate on the use case?

@michaelfavia

This comment has been minimized.

Show comment
Hide comment
@michaelfavia

michaelfavia Nov 27, 2017

I cant speak for BasPH but we have need for the ClusterIP and more importantly PORT to perform filtering of monitored metrics endpoints for prometheus.

Right now Prometheus is pinging every available port in our pods and it would be nice to scope it down but we need the service info to do that in the prometheus.yaml

michaelfavia commented Nov 27, 2017

I cant speak for BasPH but we have need for the ClusterIP and more importantly PORT to perform filtering of monitored metrics endpoints for prometheus.

Right now Prometheus is pinging every available port in our pods and it would be nice to scope it down but we need the service info to do that in the prometheus.yaml

@brian-brazil

This comment has been minimized.

Show comment
Hide comment
@brian-brazil

brian-brazil Dec 1, 2017

Member

Can you add this to the config docs please?

Member

brian-brazil commented Dec 1, 2017

Can you add this to the config docs please?

@krasi-georgiev

This comment has been minimized.

Show comment
Hide comment
@krasi-georgiev
Member

krasi-georgiev commented Feb 19, 2018

ping @BasPH

@BasPH

This comment has been minimized.

Show comment
Hide comment
@BasPH

BasPH Mar 6, 2018

Contributor

Whoops, sorry for the super late reply. I will update the docs tomorrow night. As described in #3110 and by @michaelfavia, it would be nice to have the cluster_ip exposed, e.g. to group pod metrics by the cluster_ip.

Contributor

BasPH commented Mar 6, 2018

Whoops, sorry for the super late reply. I will update the docs tomorrow night. As described in #3110 and by @michaelfavia, it would be nice to have the cluster_ip exposed, e.g. to group pod metrics by the cluster_ip.

@brian-brazil

This comment has been minimized.

Show comment
Hide comment
@brian-brazil

brian-brazil Mar 21, 2018

Member

Docs still need updating.

Member

brian-brazil commented Mar 21, 2018

Docs still need updating.

@simonpasquier

This comment has been minimized.

Show comment
Hide comment
@simonpasquier

simonpasquier Aug 1, 2018

Member

@BasPH would you have time to rebase your change and update the documentation?

Member

simonpasquier commented Aug 1, 2018

@BasPH would you have time to rebase your change and update the documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment