Set MaxIdleConnsPerHost alongside MaxIdleConns #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The blackbox exporter can manage 1k probes per second per core, so I'd suggest at least 1k. |
Otherwise it defaults to 2, and Go will close extra connections as soon as a request is finished. See golang/go#13801
bboreham
force-pushed
the
set-maxidleconnsperhost
branch
from
594f5db
to
b74f5f9
Compare
|
OK, changed to 1,000 |
|
Thanks! |
alexellis
added a commit
to openfaas/faas
that referenced
this pull request
Jan 18, 2019
- due to what appears to be a frequent issue with the Go HTTP client some tweaks were needed to the HTTP client used for reverse proxying to prevent CoreDNS from rejecting connections. The following PRs / commits implement similar changes in Prometheus and Minio. prometheus/prometheus#3592 minio/minio#5860 Under a 3-node (1-master) kubeadm cluster running on bare metal with Ubuntu 18.04 I was able to send 100k requests with 1000 being concurrent with no errors being returned by hey. ``` hey -n 100000 -c 1000 -m=POST -d="hi" \ http://192.168.0.26:31112/function/go-echo ``` The go-echo function is based upon the golang-http template in the function store using the of-watchdog. Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
11 tasks
alexellis
added a commit
to openfaas/faas
that referenced
this pull request
Feb 4, 2019
- due to what appears to be a frequent issue with the Go HTTP client some tweaks were needed to the HTTP client used for reverse proxying to prevent CoreDNS from rejecting connections. The following PRs / commits implement similar changes in Prometheus and Minio. prometheus/prometheus#3592 minio/minio#5860 Under a 3-node (1-master) kubeadm cluster running on bare metal with Ubuntu 18.04 I was able to send 100k requests with 1000 being concurrent with no errors being returned by hey. ``` hey -n 100000 -c 1000 -m=POST -d="hi" \ http://192.168.0.26:31112/function/go-echo ``` The go-echo function is based upon the golang-http template in the function store using the of-watchdog. Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
kiku-jw
pushed a commit
to kiku-jw/faas
that referenced
this pull request
Mar 7, 2019
- due to what appears to be a frequent issue with the Go HTTP client some tweaks were needed to the HTTP client used for reverse proxying to prevent CoreDNS from rejecting connections. The following PRs / commits implement similar changes in Prometheus and Minio. prometheus/prometheus#3592 minio/minio#5860 Under a 3-node (1-master) kubeadm cluster running on bare metal with Ubuntu 18.04 I was able to send 100k requests with 1000 being concurrent with no errors being returned by hey. ``` hey -n 100000 -c 1000 -m=POST -d="hi" \ http://192.168.0.26:31112/function/go-echo ``` The go-echo function is based upon the golang-http template in the function store using the of-watchdog. Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it defaults to 2, and Go will close extra connections as soon as a request is finished.
See golang/go#13801
I chose the number
1001000 arbitrarily; it should be at least as high as the the number of services you expect to poll at the same IP address, or the number of parallelremote_writeoperations.Fixes #3510