Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change max/min over_time to handle NaNs properly #4386

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@jacksontj
Copy link
Contributor

jacksontj commented Jul 14, 2018

We only want to return a NaN if the NaN is the only value

Fixes #4385

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 14, 2018

You can use the usual PromQL tests for this, no need to write code. You should also test a series with just NaNs.

@jacksontj jacksontj force-pushed the jacksontj:nan branch 3 times, most recently Sep 25, 2018

Change max/min over_time to handle NaNs properly
We only want to return a NaN if the NaN is the only value

Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>

Fixes #4385

@jacksontj jacksontj force-pushed the jacksontj:nan branch to 316e72a Sep 25, 2018

@jacksontj

This comment has been minimized.

Copy link
Contributor Author

jacksontj commented Sep 25, 2018

Updated with tests in the functions.test

@brian-brazil brian-brazil merged commit abf6fe0 into prometheus:master Sep 26, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Sep 26, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.