Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web interface Quality of Life improvements #5201

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@MashaNemt
Copy link
Contributor

MashaNemt commented Feb 10, 2019

Fixes #4599 and introduces a small QoL improvement.

  1. Resize text-input area on Graph page not only on text input, but on mouseclick as well. It helps to avoid tediously inputting something in the fields of interest on page reload;
  2. Remember "All"/"Unhealthy" choice on target-overview when reloading page.

@MashaNemt MashaNemt force-pushed the MashaNemt:qol-improvements branch Feb 10, 2019

@zuzzas

This comment has been minimized.

Copy link

zuzzas commented Feb 11, 2019

@juliusv, care to take a look? Seems really useful.

web/ui/static/js/targets.js Outdated
$("div label:nth-child(1)").addClass("active");
$(".table-container").each(showAll);
}
else if (localStorage.selectedTab == "unhealthy-targets") {

This comment has been minimized.

Copy link
@juliusv

juliusv Feb 11, 2019

Member

Style-wise, could you put this on the same line as the brace above it? (} else if (...).

This comment has been minimized.

Copy link
@MashaNemt

MashaNemt Feb 11, 2019

Author Contributor

Done.

web/ui/static/js/targets.js Outdated
@@ -21,6 +21,15 @@ function showUnhealthy(_, container) {
}

function init() {
if (!localStorage.selectedTab || localStorage.selectedTab == "all-targets"){
$("div label:nth-child(1)").addClass("active");

This comment has been minimized.

Copy link
@juliusv

juliusv Feb 11, 2019

Member

Maybe slightly better to find the labels by ID (all-targets / unhealthy-targets) and set the parent active?

This comment has been minimized.

Copy link
@MashaNemt

MashaNemt Feb 11, 2019

Author Contributor

Done.

Web UI QoL improvements
1. Added an ability to resize text area on mouseclick
2. Remember selected target status button on page reload

Signed-off-by: Maria Nemtinova <nemtinovamasha@gmail.com>

@MashaNemt MashaNemt force-pushed the MashaNemt:qol-improvements branch to 644ecb0 Feb 11, 2019

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Feb 11, 2019

👍 Thanks!

@juliusv juliusv merged commit 8e3a39f into prometheus:master Feb 11, 2019

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

yeya24 added a commit to yeya24/prometheus that referenced this pull request Feb 16, 2019

Web UI QoL improvements (prometheus#5201)
1. Added an ability to resize text area on mouseclick
2. Remember selected target status button on page reload

Signed-off-by: Maria Nemtinova <nemtinovamasha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.