Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: Fix sorting of result from (*Manager).RuleGroups #5260

Merged
merged 1 commit into from Feb 23, 2019

Conversation

Projects
None yet
2 participants
@dsymonds
Copy link
Contributor

commented Feb 23, 2019

The previous code was defective in that it never sorted groups within a
file due to doing a multi-key sort incorrectly.

Signed-off-by: David Symonds dsymonds@gmail.com

rules: Fix sorting of result from (*Manager).RuleGroups
The previous code was defective in that it never sorted groups within a
file due to doing a multi-key sort incorrectly.

Signed-off-by: David Symonds <dsymonds@gmail.com>
@dsymonds

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2019

@juliusv because I noticed it in the web UI causing rule groups to jump around due to non-determinism.

It looks like this has been bad since 5ff283a (June 2017).

@juliusv

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

👍 Thanks!

@juliusv juliusv merged commit 46361a7 into prometheus:master Feb 23, 2019

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.