Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when aggregator param is not a literal. #5290

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
4 participants
@brian-brazil
Copy link
Member

brian-brazil commented Mar 1, 2019

The return value for checkForSeriesSetExpansion
is always nil, simplify.

Fixes #5276

Signed-off-by: Brian Brazil brian.brazil@robustperception.io

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Mar 1, 2019

Fixes #5276

@codesome

This comment has been minimized.

Copy link
Member

codesome commented Mar 1, 2019

This seems to fix the problem. Can we also have a test for topk? LGTM otherwise.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Mar 2, 2019

👍

Fix panic when aggregator param is not a literal.
The return value for checkForSeriesSetExpansion
is always nil, simplify.

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>

@brian-brazil brian-brazil force-pushed the scalar-crash branch from 776824b to 858c363 Mar 4, 2019

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Mar 4, 2019

Can we also have a test for topk?
Done

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Mar 4, 2019

👍

@codesome codesome referenced this pull request Mar 4, 2019

Merged

*: cut 2.8.0-rc.0 #5287

@codesome codesome merged commit cfb9135 into master Mar 4, 2019

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.