Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Display correct values for the retention in the flags web gui. #5322
This will change the value in the flags. But it is confusing: if I add a maxbytes retention, the retention flag will change even if I do not change the retention flag.
I would propose to move that information to the Runtime and Build info page, by creating two metrics:
What do you think?
That could go in 2.9 ofc.
the flag will change only when no time or size retention is set and the default of 15d is applied. The behaviour hasn't changed since 2.7
I don't see why would we move it under Runtime and Build.
aaah yeah that is a good way to think about it. otherwise if you miss the logs it is weird to see 15d of retention when you didn't pass anything as a flag.
I like the idea and will look into it.