Skip to content

remote-read: streamed chunked server side; Extended protobuf; Added chunked, checksumed reader #5703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwplotka merged 20 commits into from
Aug 19, 2019
Merged

remote-read: streamed chunked server side; Extended protobuf; Added chunked, checksumed reader #5703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
46943c6
remote-read: Extended remote read proto with negotiation and chunked …
bwplotka Jun 20, 2019
a91ee49
remote-read: Added stream writer and reader.
bwplotka Jun 21, 2019
a5d0e81
remote-read: added server side chunked streaming support.
bwplotka Jun 20, 2019
f02a261
Updated github.com/opentracing-contrib/go-stdlib to latest version fo…
bwplotka Jul 5, 2019
c4ebc94
Fixed maxChunks bug and extended unit test.
bwplotka Jul 5, 2019
0bab6be
Fixed typo in comments.
bwplotka Jul 5, 2019
030ccfa
Addressed comments.
bwplotka Jul 20, 2019
866e229
Reverted to the SAMPLED option being explicit enum for response type …
bwplotka Jul 29, 2019
1e585e0
Added CRC32 checksum to ChunkedReader/Writer.
bwplotka Jul 29, 2019
8f1b9ca
Fixed errors found by lint.
bwplotka Jul 29, 2019
12e0a2e
Addressed Brian's comments.
bwplotka Jul 30, 2019
b46c0f3
Moved to bytes limit.
bwplotka Jul 30, 2019
9d3c2cc
Adjusted bytes limit.
bwplotka Aug 14, 2019
bd8bf91
Merge branch 'master' into rr
bwplotka Aug 14, 2019
e17e618
Merge branch 'master' into rr
bwplotka Aug 15, 2019
442412a
Addressed comments.
bwplotka Aug 15, 2019
f0af404
Regenerate protobuf files.
bwplotka Aug 15, 2019
88f5f95
Addressed Krasi & Brian's comments.
bwplotka Aug 19, 2019
939d1b4
Removed vague comment line.
bwplotka Aug 19, 2019
3764a9b
Added comment.
bwplotka Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/prometheus/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,15 @@ func main() {
a.Flag("storage.remote.flush-deadline", "How long to wait flushing sample on shutdown or config reload.").
Default("1m").PlaceHolder("<duration>").SetValue(&cfg.RemoteFlushDeadline)

a.Flag("storage.remote.read-sample-limit", "Maximum overall number of samples to return via the remote read interface, in a single query. 0 means no limit.").
a.Flag("storage.remote.read-sample-limit", "Maximum overall number of samples to return via the remote read interface, in a single query. 0 means no limit. This limit is ignored for streamed response types.").
Default("5e7").IntVar(&cfg.web.RemoteReadSampleLimit)

a.Flag("storage.remote.read-concurrent-limit", "Maximum number of concurrent remote read calls. 0 means no limit.").
Default("10").IntVar(&cfg.web.RemoteReadConcurrencyLimit)

a.Flag("storage.remote.read-max-bytes-in-frame", "Maximum number of bytes in a single frame for streaming remote read response types before marshalling. Note that client might have limit on frame size as well. 1MB as recommended by protobuf by default.").
Default("1048576").IntVar(&cfg.web.RemoteReadBytesInFrame)

a.Flag("rules.alert.for-outage-tolerance", "Max time to tolerate prometheus outage for restoring \"for\" state of alert.").
Default("1h").SetValue(&cfg.outageTolerance)

Expand Down
Loading