Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage/local tests for 32-bit systems #665

Merged
merged 1 commit into from Apr 30, 2015

Conversation

Projects
None yet
3 participants
@chkno
Copy link
Contributor

commented Apr 30, 2015

No description provided.

@fabxc

This comment has been minimized.

Copy link
Member

commented Apr 30, 2015

Cool, thanks! 👍

@juliusv

This comment has been minimized.

Copy link
Member

commented Apr 30, 2015

Oh, interesting, thanks. I would have incorrectly assumed that Go would automatically infer a 64-bit integer type for a >32-bit constant.

👍

fabxc added a commit that referenced this pull request Apr 30, 2015

Merge pull request #665 from chkno/master
Fix storage/local tests for 32-bit systems

@fabxc fabxc merged commit b8fa0a9 into prometheus:master Apr 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fabxc

This comment has been minimized.

Copy link
Member

commented Apr 30, 2015

@juliusv, I was wondering about the same thing.
If not explicitly typed the type is implied on assignment/usage.

@chkno

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2015

The variadic ...interface{} argument to Errorf seems to try to convert it to an int rather than an int64. http://play.golang.org/p/u2WWycGJuL

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this pull request Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.