Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim graphLink to avoid broken URLs #753

Closed
wants to merge 1 commit into from

Conversation

benley
Copy link

@benley benley commented Jun 1, 2015

Without this, if -web.path-prefix was set to the default value of "/"
then the sample consoles would produce links starting with "//graph#",
which break things.

Without this, if -web.path-prefix was set to the default value of "/"
then the sample consoles would produce links starting with "//graph#",
which break things.

Change-Id: I921d183546e964da8434c0af3fedce97dabe2b1b
@juliusv
Copy link
Member

juliusv commented Jun 1, 2015

Thanks! But I think the sane solution is to not have the pathPrefix contain the trailing slash at all. PR for that: #754

Closing this one.

@juliusv juliusv closed this Jun 1, 2015
@benley benley deleted the fixGraphLink branch June 1, 2015 18:40
simonpasquier pushed a commit to simonpasquier/prometheus that referenced this pull request Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants