New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument WAL fsync #162

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
3 participants
@BasPH
Contributor

BasPH commented Oct 4, 2017

Instrumented the WAL and exposed fsync duration metric as suggested in #81.

@fabxc

This comment has been minimized.

Show comment
Hide comment
@fabxc

fabxc Oct 4, 2017

Member

Thanks. Change looks good in general.
Just needs callers of the constructor to be adjusted so it compiles :)

Member

fabxc commented Oct 4, 2017

Thanks. Change looks good in general.
Just needs callers of the constructor to be adjusted so it compiles :)

@BasPH

This comment has been minimized.

Show comment
Hide comment
@BasPH

BasPH Oct 4, 2017

Contributor

Whoops my bad, missed something while committing. I pushed again and now tests fail at TestWALRestoreCorrupted but I cannot point out what's failing. Tests pass on my machine, do you happen to know what's wrong?

Contributor

BasPH commented Oct 4, 2017

Whoops my bad, missed something while committing. I pushed again and now tests fail at TestWALRestoreCorrupted but I cannot point out what's failing. Tests pass on my machine, do you happen to know what's wrong?

@gouthamve

This comment has been minimized.

Show comment
Hide comment
@gouthamve

gouthamve Oct 5, 2017

Member

Looks like a flake, restarted the build and it succeeded!

Member

gouthamve commented Oct 5, 2017

Looks like a flake, restarted the build and it succeeded!

@fabxc

This comment has been minimized.

Show comment
Hide comment
@fabxc

fabxc Oct 5, 2017

Member

Thanks! 👍

Member

fabxc commented Oct 5, 2017

Thanks! 👍

@fabxc fabxc merged commit 27f1b8a into prometheus:master Oct 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@BasPH BasPH deleted the BasPH:fsync-duration branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment