Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _total from prometheus_tsdb_storage_blocks_bytes #506

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@brian-brazil
Copy link
Member

brian-brazil commented Jan 22, 2019

Signed-off-by: Brian Brazil brian.brazil@robustperception.io

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Jan 23, 2019

maybe also update
prometheus_tsdb_size_retentions,
prometheus_tsdb_time_retentions

and add this to the CHANGELOG

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Jan 23, 2019

Those are counters, so there's no need to change them.

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Jan 23, 2019

ok I am not that familiar with the naming convention so will leave it to you.

LGTM

@codesome

This comment has been minimized.

Copy link
Member

codesome commented Jan 23, 2019

A CHANGELOG entry and we should be good to go.

Remove _total from prometheus_tsdb_storage_blocks_bytes
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>

@brian-brazil brian-brazil force-pushed the blocks-metric branch from 93b38bb to b7a602b Jan 23, 2019

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Jan 23, 2019

Done

@krasi-georgiev krasi-georgiev merged commit 5db1625 into master Jan 23, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@krasi-georgiev krasi-georgiev deleted the blocks-metric branch Jan 23, 2019

@@ -10,6 +12,7 @@
- [REMOVED] `PrefixMatcher` is considered unused so was removed.
- [CLEANUP] `Options.WALFlushInterval` is removed as it wasn't used anywhere.
- [FEATURE] Add new `LiveReader` to WAL pacakge. Added to allow live tailing of a WAL segment, used by Prometheus Remote Write after refactor. The main difference between the new reader and the existing `Reader` is that for `LiveReader` a call to `Next()` that returns false does not mean that there will never be more data to read.
- [CHANGE] Empty blocks are not written during compaction [#374](https://github.com/prometheus/tsdb/pull/374)

This comment has been minimized.

Copy link
@codesome

codesome Jan 23, 2019

Member
Suggested change
- [CHANGE] Empty blocks are not written during compaction [#374](https://github.com/prometheus/tsdb/pull/374)

This comment has been minimized.

Copy link
@krasi-georgiev

krasi-georgiev Jan 23, 2019

Member

oo shoot I missed that.

This comment has been minimized.

Copy link
@krasi-georgiev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.