Improve rsh arguments quoting #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem: rsh passes through arguments to docker compose unquoted.
This makes it impossible to run commands like:
% rsh psql -c 'select 1'
The solution: switch to bash and use arrays to hold arguments.
The downside is that's less portable but hopefully portable enough...
jayclassless
approved these changes
Sep 30, 2020
xitology
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: rsh passes through arguments to docker compose unquoted.
This makes it impossible to run commands like:
The solution: switch to bash and use arrays to hold arguments.
The downside is that's less portable but hopefully portable enough...