fix(webui): address PR review feedback for eval copy functionality

- Add useCallback wrappers for handleSaveEvalName and handleCopyEval to prevent unnecessary re-renders
- Add error toast notifications for failed copy/rename operations
- Fix Date.now() inefficiency in Eval.copy() batch loop by calling once per batch instead of per result
- Replace deprecated onKeyPress with onKeyDown in ConfirmEvalNameDialog
- Fix logging consistency to use 'id' variable instead of 'req.params.id' in error handler

Author: mldangelo

src/app/src/pages/eval/components/ConfirmEvalNameDialog.tsx

@@ -86,7 +86,7 @@ export const ConfirmEvalNameDialog = ({
     }
   };
 
-  const handleKeyPress = (event: React.KeyboardEvent) => {
+  const handleKeyDown = (event: React.KeyboardEvent) => {
     if (event.key === 'Enter' && !event.shiftKey) {
       event.preventDefault();
       handleConfirm();
@@ -120,7 +120,7 @@ export const ConfirmEvalNameDialog = ({
           label={label}
           value={name}
           onChange={(e) => setName(e.target.value)}
-          onKeyPress={handleKeyPress}
+          onKeyDown={handleKeyDown}
           margin="normal"
           error={!!error}
           helperText={

src/app/src/pages/eval/components/ResultsView.tsx

@@ -388,48 +388,72 @@ export default function ResultsView({
     [updateColumnVisibility],
   );
 
-  const handleSaveEvalName = async (newName: string) => {
-    invariant(config, 'Config must be loaded before updating its description');
-    const newConfig = { ...config, description: newName };
-
-    const response = await callApi(`/eval/${evalId}`, {
-      method: 'PATCH',
-      headers: {
-        'Content-Type': 'application/json',
-      },
-      body: JSON.stringify({ config: newConfig }),
-    });
+  const handleSaveEvalName = React.useCallback(
+    async (newName: string) => {
+      try {
+        invariant(config, 'Config must be loaded before updating its description');
+        const newConfig = { ...config, description: newName };
 
-    if (!response.ok) {
-      throw new Error('Failed to update eval name');
-    }
+        const response = await callApi(`/eval/${evalId}`, {
+          method: 'PATCH',
+          headers: {
+            'Content-Type': 'application/json',
+          },
+          body: JSON.stringify({ config: newConfig }),
+        });
 
-    setConfig(newConfig);
-  };
+        if (!response.ok) {
+          throw new Error('Failed to update eval name');
+        }
+
+        setConfig(newConfig);
+      } catch (error) {
+        console.error('Failed to update eval name:', error);
+        showToast(
+          `Failed to update eval name: ${error instanceof Error ? error.message : 'Unknown error'}`,
+          'error',
+        );
+        throw error;
+      }
+    },
+    [config, evalId, setConfig, showToast],
+  );
 
-  const handleCopyEval = async (description: string) => {
-    invariant(evalId, 'Eval ID must be set before copying');
+  const handleCopyEval = React.useCallback(
+    async (description: string) => {
+      try {
+        invariant(evalId, 'Eval ID must be set before copying');
 
-    const response = await callApi(`/eval/${evalId}/copy`, {
-      method: 'POST',
-      headers: {
-        'Content-Type': 'application/json',
-      },
-      body: JSON.stringify({ description }),
-    });
+        const response = await callApi(`/eval/${evalId}/copy`, {
+          method: 'POST',
+          headers: {
+            'Content-Type': 'application/json',
+          },
+          body: JSON.stringify({ description }),
+        });
 
-    if (!response.ok) {
-      throw new Error('Failed to copy evaluation');
-    }
+        if (!response.ok) {
+          throw new Error('Failed to copy evaluation');
+        }
 
-    const { id: newEvalId, distinctTestCount } = await response.json();
+        const { id: newEvalId, distinctTestCount } = await response.json();
 
-    // Open in new tab (Google Docs pattern)
-    window.open(`/eval/${newEvalId}`, '_blank');
+        // Open in new tab (Google Docs pattern)
+        window.open(`/eval/${newEvalId}`, '_blank');
 
-    // Show success toast
-    showToast(`Copied ${distinctTestCount.toLocaleString()} results successfully`, 'success');
-  };
+        // Show success toast
+        showToast(`Copied ${distinctTestCount.toLocaleString()} results successfully`, 'success');
+      } catch (error) {
+        console.error('Failed to copy evaluation:', error);
+        showToast(
+          `Failed to copy evaluation: ${error instanceof Error ? error.message : 'Unknown error'}`,
+          'error',
+        );
+        throw error;
+      }
+    },
+    [evalId, showToast],
+  );
 
   const handleDeleteEvalClick = async () => {
     if (window.confirm('Are you sure you want to delete this evaluation?')) {

src/models/eval.ts

@@ -1069,12 +1069,13 @@ export default class Eval {
         }
 
         // Map to new eval with new IDs and timestamps
+        const now = Date.now();
         const copiedResults = batch.map((result) => ({
           ...result,
           id: randomUUID(),
           evalId: newEvalId,
-          createdAt: Date.now(),
-          updatedAt: Date.now(),
+          createdAt: now,
+          updatedAt: now,
         }));
 
         // Insert batch

src/server/routes/eval.ts

@@ -648,7 +648,7 @@ evalRouter.post('/:id/copy', async (req: Request, res: Response): Promise<void>
 
     logger.error('Failed to copy eval', {
       error,
-      evalId: req.params.id,
+      evalId: id,
     });
     res.status(500).json({ error: 'Failed to copy evaluation' });
   }