New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with config instance variable #3

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
2 participants
@mgrachev
Contributor

mgrachev commented Mar 22, 2017

Hello!

When I run pronto with pronto-fasterer, I get the following error:

$ pronto run -c origin/develop
/Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-fasterer-3d98abea6d2b/lib/pronto/fasterer.rb:9:in `block in run': undefined method `ignored_files' for #<Pronto::Config:0x007fd6069c26e0> (NoMethodError)
	from /Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-fasterer-3d98abea6d2b/lib/pronto/fasterer.rb:8:in `reject'
	from /Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-fasterer-3d98abea6d2b/lib/pronto/fasterer.rb:8:in `run'
	from /Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-9bc0bfa8a6fa/lib/pronto/runners.rb:20:in `block in run'
	from /Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-9bc0bfa8a6fa/lib/pronto/runners.rb:13:in `each'
	from /Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-9bc0bfa8a6fa/lib/pronto/runners.rb:13:in `run'
	from /Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-9bc0bfa8a6fa/lib/pronto.rb:60:in `run'
	from /Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-9bc0bfa8a6fa/lib/pronto/cli.rb:61:in `block in run'
	from /Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-9bc0bfa8a6fa/lib/pronto/cli.rb:60:in `chdir'
	from /Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-9bc0bfa8a6fa/lib/pronto/cli.rb:60:in `run'
	from /Users/mgrachev/project/vendor/bundle/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
	from /Users/mgrachev/project/vendor/bundle/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
	from /Users/mgrachev/project/vendor/bundle/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
	from /Users/mgrachev/project/vendor/bundle/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
	from /Users/mgrachev/project/vendor/bundle/bundler/gems/pronto-9bc0bfa8a6fa/bin/pronto:6:in `<top (required)>'
	from /Users/mgrachev/project/vendor/bundle/bin/pronto:17:in `load'
	from /Users/mgrachev/project/vendor/bundle/bin/pronto:17:in `<main>'

The problem in the instance variable is @config, because It is initially declared in the method Pronto::Runner#initialize.

@mmozuras

This comment has been minimized.

Member

mmozuras commented Mar 22, 2017

Oh, how did that slip through...

@mgrachev thanks! 🙇

@mmozuras mmozuras merged commit 6fe7716 into prontolabs:master Mar 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mmozuras

This comment has been minimized.

Member

mmozuras commented Mar 22, 2017

Released as v0.8.1.

@mgrachev mgrachev deleted the mgrachev:feature/fix-config branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment