More ini directives, functions, and forbidden parameter names. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 2, 2012 07:07
directives as well and publish an error when a removed directive is encountered.
have warnings for deprecated funcations and errors for removed function. It is possible for someone to override $error in their ruleset, but that is them.
shadow super globals now cause a fatal error. This prohibits code like
function foo($_GET, $POST) {}.'
proofek
added a commit
that referenced
this pull request
Mar 2, 2012
More ini directives, functions, and forbidden parameter names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we could probably generalize the 5.3 sniffs and these 5.4 sniffs so that we would only need ruleset.xml files for each and then in the future would not be copying and pasting so much logic all over the place. There is likely to always be deprecated/removed ini directives, functions, etc.
For now, just some more checks.