From 08b6541f1b6982ee2203145bc9924b46eb44754f Mon Sep 17 00:00:00 2001
From: Chris Corsi <chris.corsi@proofgeist.com>
Date: Thu, 19 Mar 2026 14:10:39 -0400
Subject: [PATCH] fix(typegen): restore field rows visibility in metadata
 fields dialog
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The previous overflow fix (8ca7a1e) changed the scroll container from a
fixed 650px height to height: 100%, but contain: strict requires an
explicit resolved height — height: 100% couldn't resolve through the
grid parent chain, collapsing the container to 0px. Use a viewport-based
calc() height instead. Also remove the border-t on the settings form
that was visually colliding with the data grid's bottom border.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../src/components/metadata-fields-dialog/FieldsDataGrid.tsx  | 4 ++--
 .../components/metadata-fields-dialog/TableOptionsForm.tsx    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/typegen/web/src/components/metadata-fields-dialog/FieldsDataGrid.tsx b/packages/typegen/web/src/components/metadata-fields-dialog/FieldsDataGrid.tsx
index 377acf91..e9ce4658 100644
--- a/packages/typegen/web/src/components/metadata-fields-dialog/FieldsDataGrid.tsx
+++ b/packages/typegen/web/src/components/metadata-fields-dialog/FieldsDataGrid.tsx
@@ -73,13 +73,13 @@ export function FieldsDataGrid({ table, isLoading, isError, error, open }: Field
       table={table}
       tableLayout={{ width: "auto", headerSticky: true }}
     >
-      <DataGridContainer border={true} className="h-full">
+      <DataGridContainer border={true}>
         <div
           className="overflow-auto"
           ref={tableContainerRef}
           style={{
             contain: "strict",
-            height: "100%",
+            height: "calc(90vh - 280px)", // Adjust based on dialog header and search input height
           }}
         >
           <table className="w-full border-separate border-spacing-0">
diff --git a/packages/typegen/web/src/components/metadata-fields-dialog/TableOptionsForm.tsx b/packages/typegen/web/src/components/metadata-fields-dialog/TableOptionsForm.tsx
index 0f22be60..4ba0a848 100644
--- a/packages/typegen/web/src/components/metadata-fields-dialog/TableOptionsForm.tsx
+++ b/packages/typegen/web/src/components/metadata-fields-dialog/TableOptionsForm.tsx
@@ -48,7 +48,7 @@ export function TableOptionsForm({
   const isDisabled = currentTableIndex < 0 || configType !== "fmodata" || !open;
 
   return (
-    <div className="shrink-0 border-border border-t pt-4">
+    <div className="shrink-0 pt-3">
       <div className="flex gap-4">
         <FormField
           control={control}