Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update EventStoreAsyncConnection interface #21

Merged
merged 3 commits into from
Oct 24, 2018
Merged

update EventStoreAsyncConnection interface #21

merged 3 commits into from
Oct 24, 2018

Conversation

prolic
Copy link
Member

@prolic prolic commented Oct 23, 2018

bugfixes + tests

@prolic prolic added bug Something isn't working enhancement New feature or request labels Oct 23, 2018
@coveralls
Copy link

coveralls commented Oct 23, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 155

  • 10 of 10 (100.0%) changed or added relevant lines in 5 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.3%) to 46.288%
Files with Coverage Reduction New Missed Lines %
src/Internal/IdentifyInfo.php 1 80.0%
src/Internal/EventStoreConnectionLogicHandler.php 1 76.43%
src/Internal/EventStoreCatchUpSubscription.php 8 62.67%
Totals Coverage Status
Change from base Build 150: 0.3%
Covered Lines: 3859
Relevant Lines: 8337
💛 - Coveralls

@codeliner codeliner merged commit b45ed09 into master Oct 24, 2018
@codeliner codeliner deleted the changes branch October 24, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeliner codeliner codeliner approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prolic @coveralls @codeliner