Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark todo as expired feature #75

Closed
dranzd opened this issue Mar 18, 2016 · 4 comments
Closed

Mark todo as expired feature #75

dranzd opened this issue Mar 18, 2016 · 4 comments

Comments

@dranzd
Copy link
Contributor

@dranzd dranzd commented Mar 18, 2016

What's the requirement for this feature?

Is this a feature where user sends a command to mark as expired or is this marked by the system when it goes expired?

Does expired means that the current time is past that deadline?

@codeliner
Copy link
Member

@codeliner codeliner commented Mar 18, 2016

Hey @dranzd , do you want to take over the task? Yes, the system should mark a todo as expired when time has passed the deadline set by the user.

Similar to #73 a script is needed with a worker checking all open todos with a deadline and if one deadline has gone past a MarkTodoAsExpired command should be dispatched by the worker.
Let me know if you need more information.

@dranzd
Copy link
Contributor Author

@dranzd dranzd commented Mar 18, 2016

@codeliner yes I want to try it out. I've already started that and most of the questions above are just to confirm that I understand what the feature does.

@codeliner
Copy link
Member

@codeliner codeliner commented Mar 18, 2016

cool, looking forward to your PR

@codeliner
Copy link
Member

@codeliner codeliner commented Apr 22, 2016

PR merged #76 . Works like a charm.

@codeliner codeliner closed this Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.