Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify assignee when todo deadline is expired feature #82

Closed
mikemix opened this issue Jul 12, 2016 · 5 comments
Closed

Notify assignee when todo deadline is expired feature #82

mikemix opened this issue Jul 12, 2016 · 5 comments
Labels

Comments

@mikemix
Copy link
Contributor

@mikemix mikemix commented Jul 12, 2016

@prolic / @codeliner What's the requirement for this feature?

Am I supposed to subscribe to the event when the todo is marked as expired and notify the assignee about the fact?

@mikemix mikemix changed the title Notify assignee when todo deadline is expired Notify assignee when todo deadline is expired feature Jul 12, 2016
@prolic
Copy link
Member

@prolic prolic commented Jul 12, 2016

@mikemix Exactly. Additionally you need to trigger this event, measure timeout with amqp or a cronjob

@mikemix
Copy link
Contributor Author

@mikemix mikemix commented Jul 12, 2016

What event am I supposed to trigger? Though just adding a subscriber when the MarkTodoAsExpired command is dispatched would be enough.

@prolic
Copy link
Member

@prolic prolic commented Jul 12, 2016

The MarkTodoAsExpired command is not dispatched! Therefore we need a cronjob or amqp to check expired todos and send the command.

@prolic
Copy link
Member

@prolic prolic commented Jul 12, 2016

Ah sorry, the script for detecting expired todos is already there (https://github.com/prooph/proophessor-do/blob/master/scripts/mark_expired_todos.php). Sorry!

So you only need to attach a listener to TodoWasMarkedAsExpired and send an email to the user.

@codeliner
Copy link
Member

@codeliner codeliner commented Jul 30, 2016

Added with #84

We should keep the issue open until it is merged to master.

@prolic prolic closed this Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.