Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Naming convention #20
On thing I noticed during code review:
The name hints for an abstract class, but it's an abstract service factory (it should not get extended). So a better class name would be RepositoryAbstractFactory instead of AbstractRepositoryFactory.
Merely a small detail regarding the whole thing ;)
Keep on doing great stuff!
PR's are always welcome and a mongoDB adapter is something I have on my todo for long time now.
Btw I've seen your HumusAmqpModule
For the mongodb adapter: I can also imagine modelling the documents slightly different. Instead of having all events mapped as embedded objects of the aggregate, simply persist all events to a distinct event collection.
Two questions come into my mind first:
a) Do we make a pure mongodb adapter or a doctrine-mongodb adapter? I really like the abstraction doctrine-mongodb provides!
If we do something like this, which TTL will we use? MySQL InnoDB has a innodb_lock_wait_timeout of 50 secs by default f.e.
About maximum document size: We can perhabs have 2 adapters?