Skip to content

Conversation

@enumag
Copy link
Member

@enumag enumag commented Jun 18, 2019

Currently it's impossible to pass null to any of the string options. Since null is default it doesn't matter very much except for one edge case. I'm using the async_switch option by default but need to disable it in one environment - in which case I need to pass the null value to override the value from global configuration

@coveralls
Copy link

Pull Request Test Coverage Report for Build 232

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.138%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DependencyInjection/Configuration.php 6 8 75.0%
Totals Coverage Status
Change from base Build 231: 0.0%
Covered Lines: 401
Relevant Lines: 471

💛 - Coveralls

@enumag
Copy link
Member Author

enumag commented Aug 29, 2019

ping @codeliner @UFOMelkor

@codeliner codeliner merged commit bcb26f7 into prooph:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants