Skip to content

Duplicate distinct #466

Closed
xrorox opened this Issue Sep 18, 2012 · 3 comments

2 participants

@xrorox
xrorox commented Sep 18, 2012

If you call setDistinct twice whatever you reasons, it sometimes generate select distinct distinct.

Example : SELECT DISTINCT DISTINCT FROM

@willdurand
Propel member

Could you provide a unit test or some code to prove this bug?

@xrorox
xrorox commented Nov 5, 2012

I don't have the buggy code anymore. But this was equivalent to this :

$c->add(MyTablePeer::STRING_FIELD,'%'.$value.'%');
$c->setDistinct(true);
$c->add(MyTablePeer::OTHER_FIELD,$value); 
$c->setDistinct(true);

On propel 1.6.

@willdurand willdurand added a commit that referenced this issue Nov 22, 2012
@willdurand willdurand Add test to prove #466 ec6ca42
@willdurand
Propel member

I can't reproduce the issue.

@willdurand willdurand closed this Nov 22, 2012
@havvg havvg added a commit to Ormigo/Propel that referenced this issue Nov 26, 2012
@havvg havvg Merge branch 'master' into ormigo
* master: (34 commits)
  add test to verify changing version comment
  reset version comment upon saving
  Add test to prove #516
  Fix missing use statement. Closes #515
  Fix strict standards error in Archivable & Concrete Inheritance
  Add test to ensure we can add a conditions between to columns
  Add test to prove #466
  Removed unneeded else-blocks to simplify the code.
  Fix absolute path test for Windows
  Update CHANGELOG
  Remove closure to ensure BC
  fix CS
  Fix case sensitivity
  Better output in tests
  Fix missing PropelException use declaration.
  Fix findOneOrCreate with single inheritance and namespace
  sortable behavior: tests for FK scope column
  sortable behavior: fixed rank shifting on delete when there are no related objects
  fix #500 update composer.json force phing 2.4.12
  Fix a few typos
  ...

Conflicts:
	test/testsuite/generator/builder/om/GeneratedObjectRelTest.php
1949ac4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.