Issue with propel:build fails with phing 2.4.13 #500

Closed
tonivdv opened this Issue Nov 9, 2012 · 4 comments

Comments

Projects
None yet
4 participants

tonivdv commented Nov 9, 2012

There is an issue with the propel:build command since phing released 2.4.13. This has already been reported on the symfony2 mailing list (https://groups.google.com/forum/?fromgroups=#!topic/symfony2/ZZ-Cic57eLI). Here is a copy of the post:

Jeffrey Wong Post reply

Oct 27

Earlier this week we started having issues with propel:build-model not generating files. The only clue was that it only happened for new devs who had just setup the project on their machine, and then it started happening after updating vendors. I just spent an hour or so trying to figure out why what was previously working was now broken. Hopefully this will save someone else the pain.

There's an issue in phing that causes the task to appear successful, but actually fail. In verbose mode, you can see that there's a phing error. Switching to phing's tagged version 2.4.12 seems to fix the problem.

Here's the error output if anyone cares to figure out what specifically is broken.

propel-project-builder > om:

Task property (phing.tasks.system.PropertyTask) already registerd, skipping
[phing] Calling Buildfile '/Users/jwong/projects/myproject/Symfony/vendor/propel/generator/build-propel.xml' with target 'om'
parsing buildfile build-propel.xml
Overriding previous definition of property phing.project.name
Project base dir set to: /Users/jwong/projects/myproject/Symfony/vendor/propel/generator
Property ${build.properties} => build.properties
Property ${propel.home} => .
[available] Unable to find /Users/jwong/projects/myproject/Symfony/vendor/propel/generator/build.properties to set property globalBuildPopertiesExists
[phing] Error reading project file [wrapped: /Users/jwong/projects/myproject/Symfony/vendor/propel/generator/build-propel.xml:21:20: Error initializing nested element [wrapped: isset (unknown) doesn't support the 'property' attribute.]]

BUILD FINISHED

Total time: 0.1098 seconds

Maybe in the mean time propel should only support 2.4.12 ?

tonivdv commented Nov 9, 2012

Temporary work around is to specify the phing version 2.4.12 in you're own composer.json.

"phing/phing": "2.4.12",
"propel/propel-bundle":"1.1.*"

@willdurand willdurand added a commit that referenced this issue Nov 10, 2012

@willdurand willdurand Merge pull request #501 from jaugustin/patch-2
fix #500 update composer.json force phing 2.4.12
943e036

zergu commented Nov 13, 2012

Switching to phing 2.4.12 broke generated SQL in my PostgeSQL-based app. All fields are quoted with ". It ends up with errors like this: Undefined column: 7 ERROR: column "ID" does not exist. But my real problem is that when I switch to phing 2.4.13 using my local composer.json file - model is not rebuild… (0 SQL file has been generated) :[

Member

jaugustin commented Nov 13, 2012

@zergu I think your problem didn't come from the phing version change but from another propel change.

And I think your issue with phing 2.4.13 is the same as the one reported by this ticket.

zergu commented Nov 13, 2012

@jaugustin Thanks for the tip. I've checked last commits and there were some about identifier quoting. Disabling it with build property "propel.disableIdentifierQuoting: true" helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment