Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

MssqlPlatform needs own getDropIndexDDL because of different syntax #99

Open
justanerd opened this Issue · 4 comments

3 participants

justanerd Francois Zaninotto William Durand
justanerd

Hello,
if propel tries to drop a index on a mssql database it doesn't work because the generated syntax is incorrect.
Mssql needs a table name before the index name.
Here is my version of getDropIndexDDL in MssqPlatform:

         /**
     * Builds the DDL SQL to drop an Index.
     *
     * @param      Index $index
     * @return     string
     */
    public function getDropIndexDDL(Index $index)
    {
        $pattern = "
DROP INDEX %s.%s;
";
        return sprintf($pattern,$this->quoteIdentifier($index->getTable()->getName()), 
            $this->quoteIdentifier($index->getName())
        );
    }
Francois Zaninotto
Collaborator

Could you please write the patch, the unit test, and make a PR?

Ivan Tanev VanTanev referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
William Durand
Owner

ping @justanerd ?

William Durand
Owner

@justanerd any news?

William Durand
Owner

Or @CraftyShadow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.