Fix PropelModelPager::getLastPage() return type. #317

Merged
merged 1 commit into from Mar 26, 2012

Conversation

Projects
None yet
2 participants
Member

fzaninotto commented Mar 19, 2012

Turns out that PHP's ceil() converts a float to an integer but still returns... a float.
The patch forces the return type of getLastPage() by casting to integer after calling ceil().

Closes #316.

Fix PropelModelPager::getLastPage() return type.
Turns out that PHP's `ceil()` converts a float to an integer but still returns... a float.
The patch forces the return type of `getLastPage()` by casting to integer after calling `ceil()`.

Closes #316.

willdurand added a commit that referenced this pull request Mar 26, 2012

Merge pull request #317 from fzaninotto/fix_model_pager
Fix PropelModelPager::getLastPage() return type.

@willdurand willdurand merged commit 46c3f86 into propelorm:master Mar 26, 2012

Owner

willdurand commented Mar 26, 2012

Thanks, could you port this patch on Propel2?

Member

fzaninotto commented Mar 26, 2012

I'll take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment