Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Try to run tests on php5.2.17, but still incomplete #368

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants

sanemat commented May 27, 2012

DO NOT MERGE THIS. THIS IS SPIKE.

I try to run tests on php5.2.17. But still incomplete.
http://travis-ci.org/sanemat/Propel/builds/1446179

I want to add php5.2.17 to continuous integration cycle.

This pull request fails (merged 15db44d into f511569).

This intends skip tests on php5.2, but this file cause syntax error below:

Parse error: syntax error, unexpected T_STRING in /home/vagrant/5-2/Propel/test/testsuite/generator/builder/NamespaceTest.php on line 40

Call Stack:
    0.0030      54780   1. {main}() /home/vagrant/.phpenv/versions/5.2.17/bin/phpunit:0
    0.0400     394976   2. PHPUnit_TextUI_Command::main() /home/vagrant/.phpenv/versions/5.2.17/bin/phpunit:46
    0.0404     395556   3. PHPUnit_TextUI_Command->run() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:130
    0.0405     395740   4. PHPUnit_TextUI_Command->handleArguments() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:139
    0.0736     825700   5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:671
    0.0737     826288   6. PHPUnit_Util_Configuration->getTestSuite() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Configuration.php:768
    0.1280    1094824   7. PHPUnit_Framework_TestSuite->addTestFiles() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Configuration.php:848
    0.9874   16016764   8. PHPUnit_Framework_TestSuite->addTestFile() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:419
    0.9876   16017076   9. PHPUnit_Util_Fileloader::checkAndLoad() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:358
    0.9877   16017304  10. PHPUnit_Util_Fileloader::load() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Fileloader.php:79
Parse error: syntax error, unexpected T_STRING in /home/vagrant/5-2/Propel/test/testsuite/generator/builder/om/GeneratedObjectWithInterfaceTest.php on line 34

Call Stack:
    0.0026      54780   1. {main}() /home/vagrant/.phpenv/versions/5.2.17/bin/phpunit:0
    0.0210     394976   2. PHPUnit_TextUI_Command::main() /home/vagrant/.phpenv/versions/5.2.17/bin/phpunit:46
    0.0215     395556   3. PHPUnit_TextUI_Command->run() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:130
    0.0215     395740   4. PHPUnit_TextUI_Command->handleArguments() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:139
    0.0452     825700   5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:671
    0.0452     826288   6. PHPUnit_Util_Configuration->getTestSuite() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Configuration.php:768
    0.0909    1094676   7. PHPUnit_Framework_TestSuite->addTestFiles() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Configuration.php:848
    1.0991   19533680   8. PHPUnit_Framework_TestSuite->addTestFile() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:419
    1.0993   19534208   9. PHPUnit_Util_Fileloader::checkAndLoad() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:358
    1.0994   19534456  10. PHPUnit_Util_Fileloader::load() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Fileloader.php:79
Parse error: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in /home/vagrant/5-2/Propel/test/testsuite/generator/builder/om/QueryBuilderTest.php on line 228

Call Stack:
    0.0035      54780   1. {main}() /home/vagrant/.phpenv/versions/5.2.17/bin/phpunit:0
    0.0257     394976   2. PHPUnit_TextUI_Command::main() /home/vagrant/.phpenv/versions/5.2.17/bin/phpunit:46
    0.0262     395556   3. PHPUnit_TextUI_Command->run() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:130
    0.0262     395740   4. PHPUnit_TextUI_Command->handleArguments() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:139
    0.0506     825700   5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:671
    0.0506     826288   6. PHPUnit_Util_Configuration->getTestSuite() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Configuration.php:768
    0.1070    1094508   7. PHPUnit_Framework_TestSuite->addTestFiles() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Configuration.php:848
    1.2985   23769368   8. PHPUnit_Framework_TestSuite->addTestFile() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:419
    1.2987   23769632   9. PHPUnit_Util_Fileloader::checkAndLoad() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:358
    1.2987   23769868  10. PHPUnit_Util_Fileloader::load() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Fileloader.php:79
Parse error: syntax error, unexpected T_STRING in /home/vagrant/5-2/Propel/test/testsuite/runtime/query/ModelCriteriaWithNamespaceTest.php on line 43

Call Stack:
    0.0027      54780   1. {main}() /home/vagrant/.phpenv/versions/5.2.17/bin/phpunit:0
    0.0207     394976   2. PHPUnit_TextUI_Command::main() /home/vagrant/.phpenv/versions/5.2.17/bin/phpunit:46
    0.0211     395556   3. PHPUnit_TextUI_Command->run() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:130
    0.0212     395740   4. PHPUnit_TextUI_Command->handleArguments() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:139
    0.0491     825700   5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:671
    0.0491     826288   6. PHPUnit_Util_Configuration->getTestSuite() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Configuration.php:768
    0.0951    1094340   7. PHPUnit_Framework_TestSuite->addTestFiles() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Configuration.php:848    3.9371   54853068   8. PHPUnit_Framework_TestSuite->addTestFile() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:419
    3.9381   54853060   9. PHPUnit_Util_Fileloader::checkAndLoad() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:358
    3.9382   54853308  10. PHPUnit_Util_Fileloader::load() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Util/Fileloader.php:79
Parse error: syntax error, unexpected T_STRING in /home/vagrant/builds/sanemat/Propel/test/fixtures/generator/config/FoobarWithNS.php on line 3

Call Stack:
    0.0002      63296   1. {main}() /home/vagrant/.phpenv/versions/5.2.17/bin/phpunit:0
    0.0099     403488   2. PHPUnit_TextUI_Command::main() /home/vagrant/.phpenv/versions/5.2.17/bin/phpunit:46
    0.0099     404076   3. PHPUnit_TextUI_Command->run() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:130
    1.5544   57942260   4. PHPUnit_TextUI_TestRunner->doRun() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/Command.php:192
    1.5603   58262116   5. PHPUnit_Framework_TestSuite->run() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/TextUI/TestRunner.php:325
   19.8063  172830936   6. PHPUnit_Framework_TestSuite->run() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:705
   19.8072  172833556   7. PHPUnit_Framework_TestSuite->runTest() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:745
   19.8072  172833656   8. PHPUnit_Framework_TestCase->run() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestSuite.php:772
   19.8072  172833756   9. PHPUnit_Framework_TestResult->run() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestCase.php:751
   19.8073  172834708  10. PHPUnit_Framework_TestCase->runBare() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestResult.php:649
   19.8074  172875896  11. PHPUnit_Framework_TestCase->runTest() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestCase.php:804
   19.8074  172876804  12. ReflectionMethod->invokeArgs() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestCase.php:942
   19.8074  172876908  13. GeneratorConfigTest->testGetClassnameWithClassAndNamespace() /home/vagrant/.phpenv/versions/5.2.17/pear/PHPUnit/Framework/TestCase.php:942

sanemat commented May 27, 2012

Support php5.2 is painful :(
Would you give me some advice, please?

all failure are caused by namespace those file should ba completly skipped in the phpunit.xml (a php 5.2 special version)

I try to fix your shell script to compile phar extension on travis, but composer.phar can't work on php 5.2
jaugustin/Propel@acb96c1

we need a script that load phing without composer

Member

jaugustin commented May 27, 2012

@sanemat yes it's not easy to support php 5.2, all stuff added in test with namespace will fail with php 5.2.

we need to exclude from the test all php 5.3 tests files, and maybe split fixtures/tests that we created with namespace in php5.2 compatible tests files.
To do that we need a custom phpunit.xml for php 5.2 tests

Owner

willdurand commented May 27, 2012

Well, 5.2 is no more supported since a long time.
It's a hard work for a poor result IMO..

sanemat commented May 28, 2012

I find php5.2 tips. http://www.propelorm.org/contribute.html
I'll try this.

Owner

willdurand commented Jun 22, 2012

Heya, any news on this?

Owner

willdurand commented Nov 3, 2012

No news, I'm closing that one. You should upgrade your PHP version, it's not suppored anymore.

@willdurand willdurand closed this Nov 3, 2012

sanemat commented Nov 3, 2012

Thanks, I agree, propel should require newer php version, PHP 5.2.4 or newer, http://www.propelorm.org/documentation/01-installation.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment