Fix for using platform class configured in build properties #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good catch, thanks! |
willdurand
added a commit
that referenced
this pull request
Jul 13, 2012
Fix for using platform class configured in build properties
|
Heya @grray, I had to revert this fix because it leads in a huge issue. You can't build model/sql stuff with different database vendors (using the runtime config) with your commit. |
I just want to have a bit different propel <=> native column mapping, not building with different database vendors. How can it be issue, if nobody have platform, specified in build properties (because it simply didn't works), in which case it will work in old way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In documentation stated, that i can specify my own platform class like this
This change fixes getConfiguredPlatform function to use platform from build properties, if specified