i18nBehavior Composite Primary Key Support #479

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants

kevpie commented Oct 2, 2012

filterByPrimaryKey needed to be able to be called for a composite primary key which exists as an array versus a string for a regular primary key.

I have no idea what else may be missing in terms of suport for saving.

This seems to work for fetching.

Looking for guidance.

Member

jaugustin commented Oct 2, 2012

Good work, could you add tests to prove that it work as expected ?

Owner

willdurand commented Oct 4, 2012

Yeah, some unit tests would be nice :)

kevpie commented Oct 4, 2012

I hope to over the weekend. I was surprised that removing the exception
passed the test suit. ;-)

Any other areas that may need work with regard to supporting composite
primary keys in this Behavior?

On Thu, Oct 4, 2012 at 4:26 PM, William Durand notifications@github.comwrote:

Yeah, some unit tests would be nice :)


Reply to this email directly or view it on GitHubhttps://github.com/propelorm/Propel/pull/479#issuecomment-9159527.

Kevin Pierce
kevpie@gmail.com
717-1341

Owner

willdurand commented Nov 22, 2012

@kevpie Hey Kevin, could you push a unit test here?

Owner

willdurand commented Dec 28, 2012

Ping @kevpie

willdurand closed this Feb 14, 2013

Member

staabm commented Feb 14, 2013

What about this change...? Closed because of inactivity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment