Add IsInteger function to ColumnMap #526

Merged
merged 4 commits into from Dec 4, 2012

Conversation

Projects
None yet
2 participants
Contributor

woodspire commented Dec 4, 2012

Second try of #520

To be used with symfony/symfony#6150

This simply add a function.

Owner

willdurand commented Dec 4, 2012

Hi, thanks for this patch. Could you add a unit test please?

@willdurand willdurand commented on an outdated diff Dec 4, 2012

runtime/lib/map/ColumnMap.php
@@ -212,6 +212,16 @@ public function isNumeric()
}
/**
+ * Whether this column is an integer
+ *
+ * @return boolean
+ */
+ public function isInteger()
+ {
+ return $this->getPdoType() === \PDO::PARAM_INT;
@willdurand

willdurand Dec 4, 2012

Owner

The indentation should be 4 spaces and you should use PDO directly, not \PDO

Contributor

woodspire commented Dec 4, 2012

I do not know what you meant by "identation should be 4 spaces", I indent my function the same way other functions were indented in the file.

Owner

willdurand commented Dec 4, 2012

Ah, then this is bad-indented in this class ;) Not a big deal then.

William Durand | http://www.williamdurand.fr

On Tue, Dec 4, 2012 at 8:05 PM, woodspire notifications@github.com wrote:

I do not know what you meant by "identation should be 4 spaces", I indent
my function the same way other functions were indented in the file.


Reply to this email directly or view it on GitHubhttps://github.com/propelorm/Propel/pull/526#issuecomment-11010326.

Contributor

woodspire commented Dec 4, 2012

I added a simple test case. ran phpunit and found no problem with it.

willdurand merged commit 894e89d into propelorm:master Dec 4, 2012

1 check passed

default The Travis build passed
Details
Owner

willdurand commented Dec 4, 2012

Perfect. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment