clearing up and down pull request...as requested,.. #544

Merged
merged 1 commit into from Dec 29, 2012

Projects

None yet

2 participants

@oschonrock

...e)

we have infinite recursion prevention already covered
also we add an optional param to clearInstancePool. if passes as true it will clearAllReferences(true) on every
instance before clearing it.

Both these options together are useful when trying to stop memory leaks due to circular references during logn running jobs dealing with a lot of data.

refer here:
#534

Oliver Schonrock teaching propel to clear UP and DOWN when calling clearAllReferences(…
…true)

we have infinite recursion prevention already covered
also we add an optional param to clearInstancePool. if passes as true it will clearAllReferences(true) on every
instance before clearing it.

Both these options together are useful when trying to stop memory leaks due to circular references during logn running jobs dealing with a lot of data.
fb20853
@willdurand willdurand added a commit that referenced this pull request Dec 29, 2012
@willdurand willdurand Fix PR #544 a51850a
@willdurand willdurand merged commit fb20853 into propelorm:master Dec 29, 2012

1 check failed

default The Travis build failed
Details
@willdurand
Member

I fixed your PR and merged. Thanks!

@oschonrock

brilliant, thanks.

just for future reference, what did you need to fix?

I am aware that there probably some coding standards (eg bracket style) and spacing issues..anything else?

Likely target release for this patch?

@willdurand
Member

You didn't escape a variable in the phpdoc block.
1.6.8 will be released soon-ish, your fix will be part of this release.

William Durand | http://www.williamdurand.fr

On Sat, Dec 29, 2012 at 11:41 AM, oschonrock notifications@github.comwrote:

brilliant, thanks.

just for future reference, what did you need to fix?

I am aware that there probably some coding standards (eg bracket style)
and spacing issues..anything else?

Likely target release for this patch?


Reply to this email directly or view it on GitHubhttps://github.com/propelorm/Propel/pull/544#issuecomment-11751336.

@havvg havvg added a commit to Ormigo/Propel that referenced this pull request Jan 2, 2013
@havvg havvg Merge branch 'master' into ormigo
* master:
  Fixes #345
  Allow the QuickGenerator to use another Platform
  Change fallback order in getTableByPhpName(). Fixes #385
  Fix initialization of internal iterator for getRelCol. fix #460
  Add a test for initialization of internal iterator for related object collection getter fix #460
  Fix PR #544
  teaching propel to clear UP and DOWN when calling clearAllReferences(true) we have infinite recursion prevention already covered also we add an optional param to clearInstancePool. if passes as true it will clearAllReferences(true) on every instance before clearing it.
  Fix CS
  Fix cast in setters. Should fix #283
  Fix inconsistency for BIGINT. Fixes #459
  Use model prefix in QueryInheritanceBuilder, fixes #542
  fix variable name on boolean filter methods
  Tests for improved ENUM handling
  Improved getValueSet() method, added ENUM getters for SQL value, set Query filter to use SQL getters
  Add PHP 5.5 to travis config
  Update generator/lib/builder/om/PHP5PeerBuilder.php
  sqlType="enum(..)" now set the valueSet attribute it is not required to use Propel::ENUM as type
7d94f67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment