/Propel

Bugfix for join equality when default join type is used #638

Merged
merged 1 commit into from Mar 30, 2013

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@arvenil @staabm @willdurand
@arvenil
Contributor

arvenil commented Mar 27, 2013

Since http://trac.propelorm.org/changeset/1959#file1 there is a bug in checking equality between two joins if you skip joinType parameter so below won't work:

$j1 = new Join('foo', 'bar');
$j2 = new Join('foo', 'bar', 'INNER JOIN');
$this->assertTrue($j1->equals($j2));

The change to bugfix this is simple, I've also added tests for other, currently working test cases.
@arvenil
Bugfix for join equality when default join type is used 
$j1 = new Join('foo', 'bar');
$j2 = new Join('foo', 'bar', 'INNER JOIN');
$this->assertTrue($j1->equals($j2));
dcace44
@staabm

This comment has been minimized.

Show comment Hide comment
@staabm

staabm Mar 27, 2013

Member

LGTM

Member

staabm commented Mar 27, 2013

LGTM

willdurand added a commit that referenced this pull request Mar 30, 2013

@willdurand
Merge pull request #638 from arvenil/fix-join-equality 
Bugfix for join equality when default join type is used
6407158

@willdurand willdurand merged commit 6407158 into propelorm:master Mar 30, 2013
1 check passed

1 check passed

default The Travis build passed
Details
@willdurand

This comment has been minimized.

Show comment Hide comment
@willdurand

willdurand Mar 30, 2013

Owner

Thanks!

Owner

willdurand commented Mar 30, 2013

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment