Fixed Bug #478 #676

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@danez
Contributor

danez commented May 3, 2013

Avoid clearing references on BaseObject in __sleep method
because this breaks setting foreign references. By cloning the
BaseObject itself we ensure the the Baseobject itself is not
changing but sleep still returning the same

@staabm

This comment has been minimized.

Show comment Hide comment
@staabm

staabm May 3, 2013

Member

could you add also a unit test?

Member

staabm commented May 3, 2013

could you add also a unit test?

Fix bug #478
Avoid clearing references on BaseObject in __sleep method
because this breaks setting foreign references. By cloning the
BaseObject itself we ensure the the Baseobject itself is not
changing when calculating the has code
Added Unit-Tests for the bug
@danez

This comment has been minimized.

Show comment Hide comment
@danez

danez May 3, 2013

Contributor

Ok I'm now waiting for travis, but it looks promising.
I squashed everything in one commit.

The clone is now in BaseObject::hashCode()

Added a test for #478 that ensures that the set methods for Objects and Collections are not loosing references.

Contributor

danez commented May 3, 2013

Ok I'm now waiting for travis, but it looks promising.
I squashed everything in one commit.

The clone is now in BaseObject::hashCode()

Added a test for #478 that ensures that the set methods for Objects and Collections are not loosing references.

@danez

This comment has been minimized.

Show comment Hide comment
@willdurand

This comment has been minimized.

Show comment Hide comment
@willdurand

willdurand May 3, 2013

Owner

Looks good. Does your tests fail without your fix?

Owner

willdurand commented May 3, 2013

Looks good. Does your tests fail without your fix?

@danez

This comment has been minimized.

Show comment Hide comment
@danez

danez May 3, 2013

Contributor

In our project we were using the ObjectGenerator from Version 1.6.4 and the runtime was from 1.6.9 . Which was the main issue. Don't ask why 👎 After fixing this it runs now, but I think the problem still exists in cross references. I'll try to reproduce it now and if cannot i will close the bug. If I can reproduce it I will do a new pull request.

Contributor

danez commented May 3, 2013

In our project we were using the ObjectGenerator from Version 1.6.4 and the runtime was from 1.6.9 . Which was the main issue. Don't ask why 👎 After fixing this it runs now, but I think the problem still exists in cross references. I'll try to reproduce it now and if cannot i will close the bug. If I can reproduce it I will do a new pull request.

@danez danez closed this May 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment