GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
When using Postgres, the versionable behavior produces invalid column names for the *_ids and *_versions columns, because the foreign table name it uses as a prefix includes the Postgres schema name and a dot. This pull request uses getCommonName() instead of getName() for the table name when generating the column names, thus leaving off the schema prefix.
This replaces the pull request submitted a while back as #498.
fix invalid id and version column names (with schema prefix) generate…
…d from Versionable with Postgres
could you add a testcase which fails without your patch?
well yeah, a test case would be nice.
Sorry, I haven't had time to figure out the testing yet. It looks like the Versionable tests all use a SQLite database, but I guess I can stick a Versionable test into the Postgres testing.
Fix from issue propelorm/Propel#693
Has this issue been fixed?