fix column names in versionable with Postgres #693

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

kcivey commented May 22, 2013

When using Postgres, the versionable behavior produces invalid column names for the *_ids and *_versions columns, because the foreign table name it uses as a prefix includes the Postgres schema name and a dot. This pull request uses getCommonName() instead of getName() for the table name when generating the column names, thus leaving off the schema prefix.

This replaces the pull request submitted a while back as #498.

Member

staabm commented May 22, 2013

could you add a testcase which fails without your patch?

Owner

willdurand commented May 22, 2013

well yeah, a test case would be nice.

Owner

willdurand commented May 29, 2013

ping @kcivey

kcivey commented May 29, 2013

Sorry, I haven't had time to figure out the testing yet. It looks like the Versionable tests all use a SQLite database, but I guess I can stick a Versionable test into the Postgres testing.

crzdeveloper added a commit to crzdeveloper/propel-versionable that referenced this pull request May 21, 2015

tacman commented Aug 17, 2015

Has this issue been fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment