The work in progress is available here: master...kill-peer
Constants moved to their new place. I'm fixing tests right now (the most part is green).
When it will be done, each method will be moved one by one. Any help is welcome.
I will help you with that big task.
I fixed somes tests ;)
I work On fixing Versionnable tests (contante issues)
PS: leave this open until it's done ;)
I'm still working on the NestedSet behavior btw :)
Sortable: I've started a refactoring to remove the PEER class, and to fix some tests.
I work on timestampable to fix tests
I moved last contants and enum from Peer to TableMap
All tests are green (with a dirty fix to prevent DSN conflict between tests)
Next step $instances (instance pooling) and static methods, I think we should write Traits for mosts of those statics methods that didn't have any specific code.
Yep, the use of traits is a good idea!
...Peer::retreiveByPk* removed and replace by ...Query::create()->findPk*
WIP move instancePool 4 failures left
the failling tests are related to clearRelatedInstancePool (not wet correctly moved)
No wet? it's because you are D.R.Y. !!
Great to see we're around the corner.
haha "wet" and "dry" ;)
Not wet because it was after ski coding ;) but I mean not yet
move instancePool done, tests green
I fix issues with yaml 2.1.7 that break tests ;)
I work on moving fields attributes and static methods
Yes i did that but not yet pushed
Just out of curiosity, how complete is this task?
70% I guess.
Will Generator\Builder\Om\PeerBuilder be removed with this issue too?
Ah, ok. Already a new place for Base\*Peer::populateObject found?
So anything from Peer goes to TableMap?
I mean especially the do* methods.
Not only in TableMap. Some methods have been moved in ActiveQuery classes (doCount, doSelect...now are in ModelCriteria), instance pool methods to InstancePoolTrait. Get a look at @jaugustin's last commits for details.
Ah ok, I've took a look at it: BasePeer::doDelete https://github.com/propelorm/Propel2/blob/master/src/Propel/Runtime/Util/BasePeer.php#L58-L114
will thus be moved into https://github.com/propelorm/Propel2/blob/master/src/Propel/Runtime/ActiveQuery/ModelCriteria.php#L1650-L1662 ?
So the very latest state of this work is in the master branch? I ask because in the first post above is a kill-peer branch mentioned.
However, I'm going go help out with that issue and remove the last peer stuff. So FYI, working on it now.
Done. Please take a look into #359.
Awesome! We just need to ensure it fits this RFC: #36, and it will be the end of the Peers.
Ok, who will/wanna check that commit? It's quite big and has many changes. Because I want to continue the work on Propel2 in the next weeks (because I have free resources) I want to solve more issues. The prob is that the most further changes are based on this PR and I don't want to give me then a awful merge-action. If we could get that quickly merged then it would be really awesome! If someone find something that needs to be changed regarding the RFC, just write me here and I will adjust it ASAP, so I can continue the work.
Yeah, Jérémie and I will review this PR. BTW, it seems weird to have all these "mongodb*" commit messages..
@marcj I will review your pr soon ;) Nice job
as @willdurand said, is-it possible to rebase your PR and remove/squash unrelated commits ?
@jaugustin, @willdurand, cleaned and squashed.