Removing PEER classes #183

Closed
willdurand opened this Issue Apr 23, 2012 · 49 comments

Projects

None yet

8 participants

@willdurand
Propel member

The work in progress is available here: master...kill-peer

Constants moved to their new place. I'm fixing tests right now (the most part is green).
When it will be done, each method will be moved one by one. Any help is welcome.

@jaugustin
Propel member

I will help you with that big task.

@willdurand willdurand closed this Jan 12, 2013
@jaugustin
Propel member

@willdurand

I fixed somes tests ;)

I work On fixing Versionnable tests (contante issues)

PS: leave this open until it's done ;)

@jaugustin jaugustin reopened this Jan 12, 2013
@willdurand
Propel member
@willdurand
Propel member

I'm still working on the NestedSet behavior btw :)

@willdurand
Propel member

NestedSet OK

@willdurand
Propel member

Sortable: I've started a refactoring to remove the PEER class, and to fix some tests.

@jaugustin
Propel member

Versionable OK

@jaugustin
Propel member

I work on timestampable to fix tests

@jaugustin
Propel member

I moved last contants and enum from Peer to TableMap

All tests are green (with a dirty fix to prevent DSN conflict between tests)

@jaugustin
Propel member

Next step $instances (instance pooling) and static methods, I think we should write Traits for mosts of those statics methods that didn't have any specific code.

@willdurand
Propel member

Yep, the use of traits is a good idea!

@willdurand
Propel member
@jaugustin
Propel member

...Peer::retreiveByPk* removed and replace by ...Query::create()->findPk*

@jaugustin
Propel member

WIP move instancePool 4 failures left

@willdurand
Propel member
@jaugustin
Propel member

the failling tests are related to clearRelatedInstancePool (not wet correctly moved)

@fzaninotto
Propel member

No wet? it's because you are D.R.Y. !!

@hhamon
Propel member

Great to see we're around the corner.

@willdurand
Propel member

haha "wet" and "dry" ;)

@jaugustin
Propel member

Not wet because it was after ski coding ;) but I mean not yet

@jaugustin
Propel member

move instancePool done, tests green
I fix issues with yaml 2.1.7 that break tests ;)

@willdurand
Propel member

good news!

@jaugustin
Propel member

doCount* removed

@staabm
Propel member

👏

@jaugustin
Propel member

I work on moving fields attributes and static methods

@willdurand
Propel member
@jaugustin
Propel member

Yes i did that but not yet pushed

@willdurand
Propel member

alright.

@jaugustin
Propel member

done

@jaugustin
Propel member

remove doSelectOne
remove doSelectJoin*

@guilhermeaiolfi

Just out of curiosity, how complete is this task?

@willdurand
Propel member

70% I guess.

@jaugustin
Propel member

remove doSelect
remove doSelectStmt

@willdurand
Propel member

🎆

@marcj
Propel member

Will Generator\Builder\Om\PeerBuilder be removed with this issue too?

@willdurand
Propel member

Yes

@marcj
Propel member

Ah, ok. Already a new place for Base\*Peer::populateObject found?

@willdurand
Propel member

TableMap

@marcj
Propel member

So anything from Peer goes to TableMap?
I mean especially the do* methods.

@cristianoc72
Propel member

Not only in TableMap. Some methods have been moved in ActiveQuery classes (doCount, doSelect...now are in ModelCriteria), instance pool methods to InstancePoolTrait. Get a look at @jaugustin's last commits for details.

@marcj
Propel member

Ah ok, I've took a look at it: BasePeer::doDelete https://github.com/propelorm/Propel2/blob/master/src/Propel/Runtime/Util/BasePeer.php#L58-L114
will thus be moved into https://github.com/propelorm/Propel2/blob/master/src/Propel/Runtime/ActiveQuery/ModelCriteria.php#L1650-L1662 ?

So the very latest state of this work is in the master branch? I ask because in the first post above is a kill-peer branch mentioned.

@marcj
Propel member

However, I'm going go help out with that issue and remove the last peer stuff. So FYI, working on it now.

@marcj
Propel member

Done. Please take a look into #359.

@willdurand
Propel member

Awesome! We just need to ensure it fits this RFC: #36, and it will be the end of the Peers.

@marcj
Propel member

Ok, who will/wanna check that commit? It's quite big and has many changes. Because I want to continue the work on Propel2 in the next weeks (because I have free resources) I want to solve more issues. The prob is that the most further changes are based on this PR and I don't want to give me then a awful merge-action. If we could get that quickly merged then it would be really awesome! If someone find something that needs to be changed regarding the RFC, just write me here and I will adjust it ASAP, so I can continue the work.

@willdurand
Propel member

Yeah, Jérémie and I will review this PR. BTW, it seems weird to have all these "mongodb*" commit messages..

@jaugustin
Propel member

@marcj I will review your pr soon ;) Nice job

as @willdurand said, is-it possible to rebase your PR and remove/squash unrelated commits ?

@marcj
Propel member

@jaugustin, @willdurand, cleaned and squashed.

@willdurand
Propel member

Done!

@willdurand willdurand closed this May 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment