Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

A bug in ReverseManager.php:204: $dsn is undefined #325

Closed
kadishmal opened this Issue · 3 comments

2 participants

Esen Sagynov William Durand
Esen Sagynov

ReverseManager.php:204 has the following:

    protected function getConnection()
    {
        $buildConnection = $this->connection;

        // Set user + password to null if they are empty strings or missing
        $username = isset($buildConnection['user']) && $buildConnection['user'] ? $buildConnection['user'] : null;
        $password = isset($buildConnection['password']) && $buildConnection['password'] ? $buildConnection['password'] : null;

        $con = ConnectionFactory::create(array('dsn' => $dsn, 'user' => $username, 'password' => $password), AdapterFactory::create($buildConnection['adapter']));

        return $con;
    }

$dsn on line 204 is undefined. It should be $buildConnection['dsn'].

Also line 202 sets null if a password is an empty string. This is wrong! Because If a password is set to an empty string on the database server like in CUBRID's demodb demo database, the above line sets it to null which fails the authentication.

Therefore, if necessary, only username should be set to null, but a password should remain as an empty string.

William Durand
Owner

You're right, could you write a patch?

Esen Sagynov

I've already patched for CUBRID testing. I can send a PR now, if you want.

William Durand
Owner
William Durand willdurand closed this in ff2055a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.