Avoid magic methods #565

Closed
gharlan opened this Issue Mar 5, 2014 · 2 comments

Comments

Projects
None yet
3 participants
Contributor

gharlan commented Mar 5, 2014

Why do we use magic methods for things like orderByXXX(), groupByXXX(), findByXXX() etc.?
We are generating the code, so we could generate these methods, too. The performance of real methods should be much better.

Owner

marcj commented Mar 5, 2014

Well, I don't see any performance issue with those methods as you don't fire several thousand times order, group or find. The performance is rather critical when you have hundreds of methods with those methods. That would blow up your query class which makes it less performant when you initial load/declare the class and it costs probably more memory. 👎 here.

Owner

willdurand commented Mar 16, 2014

We just can't generate all methods.

willdurand closed this Mar 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment